Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm-component-ld #506

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

alexcrichton
Copy link
Collaborator

Pulls in a fix for bytecodealliance/wasmtime#10058 in the adapters that are used by default.

@alexcrichton
Copy link
Collaborator Author

I've updated the version of Wasmtime used in CI due to bytecodealliance/actions#14 of what I suspect was causing the initial failure in CI for the first commit.

Looks like this is failing on Ubuntu 24.04, the new default of
`ubuntu-latest`, so downgrade it to have it get fixed in a separate PR.
@alexcrichton
Copy link
Collaborator Author

The last failure was due to:

2025-01-22T01:42:30.6181255Z --- /dev/null	2025-01-21 23:59:07.888380651 +0000
2025-01-22T01:42:30.6181901Z +++ /src/build/sysroot/tests/general/wasm32-wasip1.-O0.no_arg_main.cc.wasm.stderr.observed	2025-01-22 01:42:30.599406609 +0000
2025-01-22T01:42:30.6182033Z @@ -0,0 +1 @@
2025-01-22T01:42:30.6182488Z +wasmtime: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by wasmtime)
2025-01-22T01:42:30.6182497Z 
2025-01-22T01:42:30.6183124Z 380/405 Test #380: test-wasm32-wasip1.-O2.no_arg_main.cc ...............................***Failed    0.01 sec

which means that the wasmtime binary was using a newer glibc than was found on the system. Wasmtime is built in an almalinux:8 container with glibc 2.28 but the builds in this repository are done with ubuntu:18.04 which has glibc 2.27. In the interest of not changing too much in one go I've tried updating Wasmtime from 18.0.2 (which doesn't work with the installation action) to 22.0.1 which the last version of Wasmtime built in an older container (centos:7 which has since EOL'd)

I might send a second PR in the future to update the Linux containers to almalinux:8 which I believe is a non-EOL'd distro if this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants